Repository navigation
feat(core)!: require explicit application readiness - #1455
Closed
zrosenbauer wants to merge 2 commits into
Closed
zrosenbauer wants to merge 2 commits into
zrosenbauer wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: d61ff5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Bugs / Features
What is the current behavior?
Application construction starts resources implicitly. Readiness and cleanup can race, telemetry operations can prevent one another from running, and listener shutdown can complete before all resources have closed.
What is the new behavior?
await app.ready()to start workspaces, telemetry, transports, and servers, including applications without an HTTP server.Testing
Notes for reviewers
Layer 2 of 4. Depends on #1454; merge that PR first.
This cross-fork draft targets upstream
next, so its diff initially includes layer 1. The lifecycle-specific commit isd61ff5da. Rebase this branch ontonextafter #1454 merges, preserving the lifecycle commit.Review order: authoring API → explicit lifecycle → examples/scaffolding → documentation.
The untouched serverless-Hono routes have existing type errors involving
ContentfulStatusCodeandstepId; those are outside these lifecycle changes.Summary by cubic
Requires explicit application readiness: constructing an application no longer starts workspaces, telemetry, transports, or servers; call and await
app.ready()instead. Also introducesdefineAgent,defineTool,defineWorkflow, and thevoltagent()bootstrap factory as the canonical authoring API.Lifecycle
app.shutdown()is idempotent, waits for in-flight startup, and flushes traces and logs before shutting down telemetry.Migration
new Agent(...)withdefineAgent(...),tool(...)withdefineTool(...),createWorkflow(...)withdefineWorkflow(...), andnew VoltAgent(...)withawait voltagent(...).ready().AgentandVoltAgentare now type-only exports; the default export is thevoltagentfactory, and the oldtoolandcreateWorkflowexports are removed.Written for commit d61ff5d. Summary will update on new commits.