Merged
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Mid to long term I want to fix:
|
kmiller68
approved these changes
Dec 19, 2025
Contributor
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
Overall seems fine. I'm a bit mid on the counter passing since it's not fixed everywhere so it's in a weird in-between half global / half parameter state. IMO we should pick one or the other and stick with it or fix it everywhere but I'm not gonna block on it.
Contributor
Author
|
I agreed :) I will keep on refactoring a bit in follow up PRs so we can see which way works better (likely local) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to ShellFileLoader introduce a BrowserFileLoader as mid-term solution to clean up the file loading code.