Skip to content

Explicitly include index.html in Perf-Dashboard suite URL - #606

Open
betasheet wants to merge 1 commit into
WebKit:mainfrom
betasheet:perf-dashboard-index-html
Open

betasheet wants to merge 1 commit into
WebKit:mainfrom
betasheet:perf-dashboard-index-html

Conversation

@betasheet

Copy link
Copy Markdown

When running Speedometer over HTTP/HTTPS, web servers automatically resolve directory URLs (like suites/perf.webkit.org/public/v3/) to index.html. However, when running from local storage via file:// URLs (e.g., on Android), file URL loaders treat directory paths as folder listings rather than loading index.html.

All other suites in Speedometer already explicitly specify their .html entry point in suite.url. Update Perf-Dashboard to also specify index.html explicitly, and check in suites unit tests that suite URL paths end with .html.

When running Speedometer over HTTP/HTTPS, web servers automatically
resolve directory URLs (like suites/perf.webkit.org/public/v3/) to
index.html. However, when running from local storage via file:// URLs
(e.g., on Android), file URL loaders treat directory paths as folder
listings rather than loading index.html.

All other suites in Speedometer already explicitly specify their .html
entry point in suite.url. Update Perf-Dashboard to also specify
index.html explicitly, and check in suites unit tests that suite URL
paths end with .html.
@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for webkit-speedometer-preview ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 041df25
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/6afaf2faedf20e5d23c73122
😎 Deploy Preview https://deploy-preview-606--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni

Copy link
Copy Markdown
Contributor

nice! I was fixing this in the #540 PR as well.

@camillobruni
camillobruni requested a review from canova November 16, 2026 13:27

@canova canova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants