Replaced the fragile/wrong urlopen JSON mock#1540
Merged
Merged
Conversation
of TWLight.users.models.editor_global_userinfo returning FAKE_GLOBAL_USERINFO Assisted-by: Claude Opus 4.8 Bug: T352896
suecarmol
approved these changes
Jul 6, 2026
suecarmol
left a comment
suecarmol
left a comment
Contributor
There was a problem hiding this comment.
This looks good, let's merge and see if it works in CICD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FAKE_GLOBAL_USERINFO — the idiomatic approach the rest of the suite uses (other tests pass global_userinfo explicitly). This
guarantees the editor is saved before wp_editcount is read.
Assisted-by: Claude Opus 4.8
Bug: T352896