Skip to content

Updates to modbus disconnect#723

Draft
WillCodeForCats wants to merge 5 commits intomainfrom
disconnect-updates
Draft

Updates to modbus disconnect#723
WillCodeForCats wants to merge 5 commits intomainfrom
disconnect-updates

Conversation

@WillCodeForCats
Copy link
Copy Markdown
Owner

@WillCodeForCats WillCodeForCats commented Jan 4, 2025

This PR adds some things used in HA core to our disconnect function.

  • Delay 1 second on modbus close (idea from core PR#130038)
  • Delete client object (from modbus core integration)
  • Catch exceptions from close() (from modbus core integration)

@WillCodeForCats WillCodeForCats added the update Update or change to something label Jan 4, 2025
@WillCodeForCats WillCodeForCats self-assigned this Jan 4, 2025
@WillCodeForCats WillCodeForCats marked this pull request as draft February 11, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@WillCodeForCats WillCodeForCats

Labels

update Update or change to something

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@WillCodeForCats