-
Notifications
You must be signed in to change notification settings - Fork 4
feat: gate all logging behind logging feature flag
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0a9f784
feat: gate all logging behind `logging` feature flag
grumbach 7b1fad7
ci: strip logging from release binaries via --no-default-features
grumbach f31e55f
fix: restore default=["logging"] and revert --no-default-features app…
grumbach a3a643b
fix: address review findings from multi-agent consensus review
grumbach f50c522
fix: prevent shift overflow panic in merkle payment verifier
grumbach 041553d
fix: replace global RUSTFLAGS overrides with targeted cfg_attr allows
grumbach f2e021d
fix: include error details in bootstrap peers warning
grumbach 2539595
docs: document unused-variable tradeoff in logging facade
grumbach 8f2c7d6
ci: add test job for --no-default-features (no logging) path
grumbach 72938d0
fix: install Foundry in test-no-logging CI job
grumbach bc50574
ci: use debug builds for RC pre-releases to retain logging
jacderida File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For prerelease tags,
build_flagsis set to empty andprofile_dir=debug, which changes prerelease artifacts from optimized--releasebuilds to debug builds. If these prerelease binaries are meant to be representative release candidates, consider keeping--releasefor prereleases as well (but omit--no-default-featuresso logging stays enabled) and setprofile_dir=releaseaccordingly.