Conversation
Collaborator
|
Looking great, thank you @JanJakes! My only not is that a single WordPress core unit test failed on this PR. I'm not sure how much that's related to this change and how much to something in WP trunk. |
JanJakes
force-pushed
the
show-full-columns
branch
from
0e6f294 to
817e908
Compare
Member
Author
That's a lovely CI failure. I had no idea WPDB used Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new AST driver already supports
SHOW COLUMNSstatement.This PR adds support for
SHOW FULL COLUMNS.