fix(cmd): fix disabling discovery through config file #33279

[gzliudan]

Proposed changes

Ref: ethereum#33279

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request aims to fix issue ethereum#33279 by enabling V4 and V5 discovery to be disabled through the configuration file. The changes introduce a new DiscoveryV4 configuration field alongside the existing DiscoveryV5 field, add corresponding command-line flags, and modify the flag handling logic to respect configuration file settings.

Changes:

• Added DiscoveryV4 boolean field to p2p.Config struct for controlling V4 discovery
• Set default values for both DiscoveryV4 and DiscoveryV5 to true in node.DefaultConfig
• Introduced new DiscoveryV4Flag and updated DiscoveryV5Flag with new names and aliases
• Modified SetP2PConfig to only update discovery settings when flags are explicitly set, allowing config file values to be respected

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
p2p/server.go	Adds DiscoveryV4 configuration field to the Config struct
node/defaults.go	Sets default values for DiscoveryV4 and DiscoveryV5 to true for backward compatibility
cmd/utils/flags.go	Adds DiscoveryV4Flag, renames DiscoveryV5Flag, and updates SetP2PConfig to respect config file settings

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.