fix(p2p): a few minor code inspection fixes #18393#2004
fix(p2p): a few minor code inspection fixes #18393#2004AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses minor code quality improvements in the p2p package, focusing on spelling corrections, variable naming conventions, and test helper improvements.
Changes:
- Fixed spelling errors in comments ("connectiton" → "connection", "mokcer" → "mocker", "whataver" → "whatever")
- Renamed variable from snake_case to camelCase (
nodes_info→nodesInfo) following Go conventions - Added
t.Helper()to test helper function for better test failure reporting
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| p2p/simulations/network.go | Fixed typo in comment: "connectiton" → "connection" |
| p2p/simulations/mocker_test.go | Fixed typo in comment "mokcer" → "mocker" and renamed variable nodes_info → nodesInfo (4 occurrences) |
| p2p/simulations/http_test.go | Added t.Helper() to testHTTPServer test helper function |
| p2p/simulations/adapters/exec.go | Fixed typo in comment: "whataver" → "whatever" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
361b3b6 to
fc3973e
Compare
Proposed changes
Ref: ethereum#18393
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that