Skip to content

fix(p2p): a few minor code inspection fixes #18393#2004

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:p2p-inspection-fixes
Feb 6, 2026
Merged

fix(p2p): a few minor code inspection fixes #18393#2004
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:p2p-inspection-fixes

Conversation

@gzliudan
Copy link
Collaborator

Proposed changes

Ref: ethereum#18393

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 28, 2026 04:12
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses minor code quality improvements in the p2p package, focusing on spelling corrections, variable naming conventions, and test helper improvements.

Changes:

  • Fixed spelling errors in comments ("connectiton" → "connection", "mokcer" → "mocker", "whataver" → "whatever")
  • Renamed variable from snake_case to camelCase (nodes_infonodesInfo) following Go conventions
  • Added t.Helper() to test helper function for better test failure reporting

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
p2p/simulations/network.go Fixed typo in comment: "connectiton" → "connection"
p2p/simulations/mocker_test.go Fixed typo in comment "mokcer" → "mocker" and renamed variable nodes_infonodesInfo (4 occurrences)
p2p/simulations/http_test.go Added t.Helper() to testHTTPServer test helper function
p2p/simulations/adapters/exec.go Fixed typo in comment: "whataver" → "whatever"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan changed the title p2p: a few minor code inspection fixes #18393 fix(p2p): a few minor code inspection fixes #18393 Feb 5, 2026
@gzliudan gzliudan force-pushed the p2p-inspection-fixes branch from 361b3b6 to fc3973e Compare February 5, 2026 08:54
@AnilChinchawale AnilChinchawale merged commit 9d79d44 into XinFinOrg:dev-upgrade Feb 6, 2026
13 checks passed
@gzliudan gzliudan deleted the p2p-inspection-fixes branch February 6, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants