refactor(p2p): enable goimports and varcheck linters #16446

[gzliudan]

Proposed changes

Ref: ethereum#16446

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Enables/cleans up code to satisfy goimports and varcheck in the p2p/discv5 area by removing unused symbols and adjusting generated string conversion code.

Changes:

• Removed unused devp2p message code constants in p2p/peer.go.
• Removed unused imports/test variables in p2p/discv5/udp_test.go and an unused constant in p2p/discv5/table.go.
• Updated p2p/discv5/nodeevent_string.go string conversion logic for nodeEvent.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
p2p/peer.go	Drops unused message code constants.
p2p/discv5/udp_test.go	Removes unused time import and unused shared test vars.
p2p/discv5/table.go	Removes an unused constant.
p2p/discv5/nodeevent_string.go	Modifies nodeEvent.String() implementation (currently incorrect).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

nodeEvent.String() implementation is incorrect after this change: i -= 264 misaligns the timeout constants (e.g., pongTimeout is 265) and will underflow for packet event values (<264), producing wrong names/IDs (and potentially negative-looking values after uint->int64 conversion). This should be regenerated with stringer -type=nodeEvent (or restored to logic that correctly handles both ranges 0..8 and 265..267) rather than manually trimming the generated output.

Suggested change

	i -= 264
	if i >= nodeEvent(len(_nodeEvent_index)-1) {
	return "nodeEvent(" + strconv.FormatInt(int64(i+264), 10) + ")"
	}
	return _nodeEvent_name[_nodeEvent_index[i]:_nodeEvent_index[i+1]]
	switch i {
	case pongTimeout:
	return "pongTimeout"
	case pingTimeout:
	return "pingTimeout"
	case neighboursTimeout:
	return "neighboursTimeout"
	default:
	return "nodeEvent(" + strconv.FormatInt(int64(i), 10) + ")"
	}