Skip to content

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jan 29, 2026

Proposed changes

implement EIP-7939

Ref: ethereum#31989

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 29, 2026 01:32
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements EIP-7939, which adds a new CLZ (Count Leading Zeros) opcode to the EVM. The CLZ opcode counts the number of leading zero bits in a 256-bit value. To support this new opcode, a new Osaka fork is introduced, which builds on top of the Prague fork.

Changes:

  • Adds the Osaka fork configuration across all network constants (mainnet, testnet, devnet, local)
  • Implements the CLZ opcode (0x1e) that counts leading zero bits in a 256-bit value
  • Creates the Osaka instruction set that includes all Prague features plus EIP-7939

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
params/config.go Adds OsakaBlock field and IsOsaka() method to chain configuration and Rules struct
core/vm/opcodes.go Defines CLZ opcode constant (0x1e) and adds string mappings
core/vm/eips.go Implements opCLZ function and enable7939 to activate the opcode
core/vm/jump_table.go Creates newOsakaInstructionSet() that extends Prague with EIP-7939
core/vm/jump_table_export.go Updates LookupInstructionSet() to handle Osaka and Verkle forks
core/vm/evm.go Adds Osaka case to select appropriate instruction set
core/vm/instructions_test.go Adds comprehensive test cases for CLZ opcode covering edge cases
common/constants.*.go Initializes OsakaBlock for all networks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan changed the title core/vm: implement EIP-7939: CLZ opcode #31989 chore(core): implement EIP-7939: CLZ opcode #31989 Feb 4, 2026
@gzliudan gzliudan changed the title chore(core): implement EIP-7939: CLZ opcode #31989 feat(core): implement EIP-7939: CLZ opcode #31989 Feb 4, 2026
@gzliudan gzliudan force-pushed the eip31989 branch 2 times, most recently from c12af3c to 614eeb0 Compare February 6, 2026 22:00
@AnilChinchawale AnilChinchawale merged commit ec697dd into XinFinOrg:dev-upgrade Feb 10, 2026
13 checks passed
@gzliudan gzliudan deleted the eip31989 branch February 10, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants