[RFC] Clock + Volume sliders in top right#769
Open
Birdulon wants to merge 5 commits intoZeroK-RTS:masterfrom
Open
[RFC] Clock + Volume sliders in top right#769Birdulon wants to merge 5 commits intoZeroK-RTS:masterfrom
Birdulon wants to merge 5 commits intoZeroK-RTS:masterfrom
Conversation
|
Turn the interface_root Controls into Panels so they draw as rectangles, then you can better see the structure of the menu. My recollection is that the button on the top right are in a control with the username, so it would make sense to put the volume control there. On the slider itself, I become more concerned about the top right of the screen having too much packed into it. I have considered making Settings and Friends main menu options and turning the remaining big texty buttons into icons. The 'Home' button is redundant with the home button in the community tab and the logout button could become more integrated with the username, and look less like the big X in the top right of the application. |
Author
|
That is insufficiently all-encompassing. |
[settings] Make Lobby Music Volume trackbar update periodically [settings] Added Master Volume trackbar Moving panels around
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Attempts to add a little bit of convenient GUI parity from in-game to the lobby, in the form of main+music volume sliders and a clock.

I'll probably need to modify
gui_settings_window.luato refresh itsMenu Music Volumeslider, and I'll strip a lot of the commented out code before it's ready to merge, but for now I'd like some advice on making it fit the layout properly. As-is, I had to settle on what felt like hacky position values to get it to sit roughly where I wanted it, but I suspect there's a proper way of making it conform.