Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds an outbound “V2 Market” entry to the header More menu, providing quick access to the legacy V2 market site (v2-market.aave.com) using the existing external-link behavior (new tab).
Changes:
- Add a new
moreMenuItemsentry pointing tohttps://v2-market.aave.com/ - Introduce a new Lingui translatable string:
t\V2 Market``
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| link: 'https://v2-market.aave.com/', | ||
| title: t`V2 Market`, | ||
| icon: <ArrowCircleRightIcon />, |
There was a problem hiding this comment.
The new Lingui msgid V2 Market (tV2 Market) is introduced here, but the locale catalogs don’t currently contain it. In this repo, each locale commits both messages.po and compiled messages.js, so please run the Lingui extract/compile workflow and commit the updated src/locales/*/messages.po and src/locales/*/messages.js entries for this string.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Motivation
V2 Marketlink in the headerMoremenu to provide quick access to the legacy V2 market atv2-market.aave.com.Description
V2 Marketmenu item insrc/ui-config/menu-items/index.tsxthat links tohttps://v2-market.aave.com/and reuses the existing externalLinkbehavior so it opens in a new tab.Testing
yarn lint:code --file src/ui-config/menu-items/index.tsx, which completed successfully (the repo contains unrelated pre-existing lint warnings).Codex Task