Fix crash in assemble_package when manifest is at codebase root#2070
Open
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Fix crash in assemble_package when manifest is at codebase root#2070Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:mainfrom
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Kaushik <[email protected]>
Author
|
Hi @pombredanne @AyanSinhaMahapatra @tdruez @keshav-space this fixes the issue reported in scancode-action #11 happy to make any changes if needed! |
Contributor
|
Catching the exception here just silences the error, it doesn't address why it's happening in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported in : scancode-action #11
when a package manifest (e.g. pom.xml) is at the root of the input directory,
assemble_package()crashes with:this happens because packagedcode's maven handler calls
resource.parent()which returns None when there is no parent path, then passes that None toassign_package_to_resources()Fix
wrapped
handler.assemble()inassemble_package()with atry/except AttributeErrorso the pipeline logs a warning and continues instead of crashingTesting
reproduced and verified locally