Skip to content

[CNAPP-24185] : BE | Public Disk access still coming up need to confirm on check #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vickydew1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CNAPP-24185] : BE | Public Disk access still coming up need to confirm on check #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f27a803
Fixed publicNetworkAccess issue
Vickydew1 Dec 17, 2025
7ac6899
Fix VM Disk Public Access check to handle missing publicNetworkAccess
Vickydew1 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions plugins/azure/virtualmachines/vmDiskPublicAccess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,22 @@ module.exports = {
}
for (let disk of disks.data) {
if (!disk.id) continue;

if (disk.networkAccessPolicy) {
if (disk.networkAccessPolicy.toLowerCase() === 'allowall') {
helpers.addResult(results, 2, 'Disk is publicly accessible', location, disk.id);

} else if (disk.networkAccessPolicy.toLowerCase() === 'allowprivate') {
helpers.addResult(results, 0, 'Disk is not publicly accessible', location, disk.id);

} else {
helpers.addResult(results, 0, 'Disk is not publicly or privately accessible', location, disk.id);


if (!disk.publicNetworkAccess || disk.publicNetworkAccess.toLowerCase() === 'enabled') {
if (disk.networkAccessPolicy) {
if (disk.networkAccessPolicy.toLowerCase() === 'allowall') {
helpers.addResult(results, 2, 'Disk is publicly accessible', location, disk.id);

} else if (disk.networkAccessPolicy.toLowerCase() === 'allowprivate') {
helpers.addResult(results, 0, 'Disk is not publicly accessible', location, disk.id);

} else {
helpers.addResult(results, 0, 'Disk is not publicly or privately accessible', location, disk.id);
}
}
} else {
helpers.addResult(results, 0, 'Public disk access is disabled', location, disk.id);
}


}
rcb();
}, function() {
Expand Down
Loading