Add missing tests and docs from recent PRs #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #301 added first-class Azure OpenAI provider support but shipped without a dedicated documentation page. This adds: - docs/providers/azure.md with full configuration, usage, and parameter reference - Azure OpenAI entry in sidebar navigation - Azure listed as first-class provider in providers overview - OpenAI docs updated to link to dedicated Azure page instead of inlining outdated configuration cc @TheRealNeil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR #290 added support for dropping OpenAI's "developer" role messages in common format (same as "system" messages), but the messages documentation did not mention this role. This updates: - Message roles list to include developer role - Note about system messages to also mention developer role cc @TheRealNeil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR #299 added handling for higher-level gem convenience events (:text, :input_json, :citation, :thinking, :signature) but only tested :thinking and :signature. This adds coverage for the remaining three event types (:text, :input_json, :citation) to ensure they are all handled as no-ops without raising. cc @TheRealNeil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR #278 (Universal Tools & MCP Support) introduced the ToolChoiceClearing concern (62 lines) for preventing infinite tool-calling loops, but shipped without unit tests. This adds tests covering: - No-op when tool_choice is nil - Clearing when required mode and tools were used - Clearing when specific tool forced and that tool was used - Preserving when different/no tools were used - Preserving when tool_choice is auto - NotImplementedError for unimplemented abstract methods cc @TheRealNeil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR #274 (Improved Usage Tracking) introduced Usage#+ for combining statistics across multi-turn tool-calling conversations, but shipped without tests for this feature. This adds: - Basic addition combining two usage objects - Addition with nil optional fields - Addition with nil operand returns self - Chained addition simulating multi-turn accumulation cc @TheRealNeil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed the latest merged PRs and identified gaps in tests and documentation. This PR adds the missing pieces, organized as one commit per original PR:
PR #301 — Azure OpenAI Provider
docs/providers/azure.md— Dedicated Azure provider documentation page (was the only provider without one)docs/providers.md— Listed Azure as a first-class provider in the chooser guidedocs/providers/open_ai.md— Updated Azure section to link to the new dedicated page instead of inlining outdated configurationPR #290 — Developer Role Messages
docs/actions/messages.md— Addeddeveloperrole to the message roles list and updated the note about dropped roles to mention bothsystemanddeveloperPR #299 — Anthropic Streaming Fix
test/providers/anthropic/streaming_convenience_events_test.rb— Added tests for:text,:input_json, and:citationevent types (PR Fix Anthropic streaming and empty tool input errors #299 only tested:thinkingand:signature)PR #278 — Universal Tools & MCP Support
test/providers/concerns/tool_choice_clearing_test.rb— Added unit tests for theToolChoiceClearingconcern (62 lines of code, 0 lines of tests shipped). Covers all branches: nil tool_choice, required mode, specific tool forcing, auto mode, andNotImplementedErrorfor abstract methodsPR #274 — Improved Usage Tracking
test/providers/common/usage_test.rb— Added tests forUsage#+(addition) and multi-turn accumulation: basic addition, nil optional fields, nil operand, and chained three-turn accumulationTest plan
bin/test test/providers/concerns/tool_choice_clearing_test.rb test/providers/anthropic/streaming_convenience_events_test.rb test/providers/common/usage_test.rb— greencc @TheRealNeil
🤖 Generated with Claude Code