Drop support for ruby 1.9 and rails <4.1#32
Drop support for ruby 1.9 and rails <4.1#32gssbzn wants to merge 1 commit intoactiverecord-hackery:masterfrom gssbzn:drop-old-ruby
Conversation
|
Hei @seanfcarroll, any thoughts about this? :) |
|
I'd be for dropping old versions, but the tests will need to pass. Looks like they are failing on old versions of Ruby. |
|
Master seems to be failing in the exact same way: https://travis-ci.org/activerecord-hackery/polyamorous/builds/413682950?utm_source=github_status&utm_medium=notification, and this PR was recently rebased, so I'd say it's good to go? |
| s.files = `git ls-files`.split("\n") | ||
| s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") | ||
| s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | ||
| s.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } |
|
|
||
| # specify any dependencies here; for example: | ||
| # s.add_development_dependency "rspec" | ||
| # s.add_runtime_dependency "rest-client" |
There was a problem hiding this comment.
Perhaps removing the old versions from .travis.yml and re-running the tests is a good idea? https://github.com/activerecord-hackery/polyamorous/blob/master/.travis.yml
There was a problem hiding this comment.
You mean also dropping support for ruby 2.2 and ruby 2.3, or excluding those entries? In any case, tests are failing against Rails master, I guess the best solution for now would be to move the failing entries to allowed_failures.
|
I see now that this repo is no longer maintained. Maybe the repo should be archived and all issues and PRs closed to prevent further confusion? |
Dropping old and unsupported versions of ruby and RoR
|
@seanfcarroll I agree with @deivid-rodriguez . Shall we archive this repo, and do all we can to direct folks to ransack? |
|
There is a conversation around Polyamorous over at baby squeel. They are including Ransack to have access to Polyamorous. |
4 participants
Dropping old and unsupported versions of ruby and RoR