Skip to content

Conversation

@tyeth
Copy link
Member

@tyeth tyeth commented Dec 17, 2025

@tyeth tyeth marked this pull request as ready for review December 17, 2025 01:14
Copy link
Member Author

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires protobuf (adafruit/Wippersnapper_Protobuf#157) and io-rails change (https://github.com/AdafruitInternalDev/io-node/pull/198) to bring in the extra screen support.
Will be the same for the next few screens (two new drivers, think the third may reuse an existing one)

@tyeth tyeth requested a review from brentru December 17, 2025 16:13
@tyeth tyeth mentioned this pull request Dec 17, 2025
@tyeth
Copy link
Member Author

tyeth commented Dec 17, 2025

The runNetFSM and ping both cause a base class response instead of network interface overload, resulting in no network interface and an inability to scan for networks etc.

Similar to what was fixed/experienced in #830 + #829

Adding the linking changes (move WS to be Wippersnapper_WiFi type instead) from #829 solves that.

A publish retry is also added (from #697) so that components are correctly confirmed (display component) as a ping can still sometimes be acknowledged even with a stale client.
The io-node aedes broker does pingresp at a lower level than the keep alive interval timeout and in an already queued response pipeline - we could patch it as testing that locally it did help the firmware to get a proper ping failure earlier, but we rely on the subsequent publish failure instead.

@tyeth tyeth requested a review from brentru December 17, 2025 19:10
@tyeth tyeth dismissed brentru’s stale review December 18, 2025 14:10

Showing unresolved changes, but they are resolved. Will re-request review after dismissing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants