Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| "version:nightly": "yarn workspaces foreach --all --no-private -t version -d 3.0.0-nightly-$(git rev-parse --short HEAD)-$(date +'%y%m%d') && yarn apply-nightly --all", | ||
| "publish:nightly": "yarn workspaces foreach --all --no-private -t npm publish --tag nightly --access public", | ||
| "build:api-published": "node scripts/buildPublishedAPI.js", | ||
| "build:api-published": "node scripts/buildBranchAPI.js --githash=$(git log --grep='^Publish$' --oneline -1 | awk '{print $1}') --output=base-api", |
There was a problem hiding this comment.
fixes yarn check-published-apis by comparing vs the last publish commit instead of pulling from npm (see #9917 (comment)). base-api here is to point it to a different dist dir since buildBranchAPI uses branch-api by default
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
…ommit rather than just last week the latter is to handle the case where we run this flow multiple times a day or in the same week and there arent any new changes. Previously it would still use the current weeks diff results rather than reporting that there are no changes
running diff right after new release when there are new changes, running diff between releases, where there are no changes between last run, and when there are no changes from the released code
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
changed the title
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
added
tech/dev/garage week
ready for review
no testing
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 17 * * 1' # Monday 9am PST / 10am PDT (GH Actions cron is UTC) |
There was a problem hiding this comment.
from my own testing, i've found that the cron runs a bit late on github. i had a job set up for 6am pdt and it didn't run until 8:30am so it might be worth having this run a bit earlier if you want it to run before we all jump online
There was a problem hiding this comment.
oh weird, I did notice some occasional slowness with how the github action runners ran yesterday. That might explain that behavior if that was typical and not just a yesterday thing. I think we can try this out first and bump the schedule time down if people want to see the diff earlier
| - name: Build current API snapshot | ||
| run: yarn build:api-branch | ||
|
|
||
| # Build release baseline using the last Publish commit (~20 min, always fresh) |
There was a problem hiding this comment.
so does it take roughly 40 minutes to complete the job?
There was a problem hiding this comment.
in practice no, actually more like 2 minutes. I'll edit this, this was theoretical
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 17 * * 1' # Monday 9am PST / 10am PDT (GH Actions cron is UTC) |
There was a problem hiding this comment.
oh weird, I did notice some occasional slowness with how the github action runners ran yesterday. That might explain that behavior if that was typical and not just a yesterday thing. I think we can try this out first and bump the schedule time down if people want to see the diff earlier
| - name: Build current API snapshot | ||
| run: yarn build:api-branch | ||
|
|
||
| # Build release baseline using the last Publish commit (~20 min, always fresh) |
There was a problem hiding this comment.
in practice no, actually more like 2 minutes. I'll edit this, this was theoretical
Co-authored-by: Daniel Lu <danilu@adobe.com>
|
Build successful! 🎉 |
hopefully this make it so it can reason that a new api change to a component/prop that didnt have changes last week isnt actually a brand new component
|
Build successful! 🎉 |
3 participants
Github actions workflows for Chromatic and TSDiffer. I've tested the TSDiffer flow locally, but the github actions are untested yet. Whole lotta AI stuff here, but I've looked over it and it seems ok
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP