Fix review feedback: yamllint config path, agent structure diagram, and UI5 prompt outer fences#336
Merged
data-douser merged 2 commits intodd/copilot-setup/2from Mar 24, 2026
Merged
Conversation
…am, and UI5 prompt fences Co-authored-by: data-douser <[email protected]> Agent-Logs-Url: https://github.com/advanced-security/codeql-sap-js/sessions/404b2862-c982-4730-894b-d434ad2bb1ed
Copilot
AI
changed the title
[WIP] Setup .github/** for Copilot (for CodeQL)
Fix review feedback: yamllint config path, agent structure diagram, and UI5 prompt outer fences
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments from PR #335.
What This PR Contributes
yamllintcommand accuracy — Updated invocations ingithub-maintenance-agent.mdandgithub_maintenance.prompt.mdto explicitly pass-c .github/.yamllint, since yamllint does not auto-discover configs outside the CWD:github-maintenance-agent.mdwith a wildcard entry to avoid drift:```prompt/```fences from all three UI5 prompt files (ui5_framework_codeql_dev.prompt.md,ui5_framework_codeql_lib.prompt.md,ui5_framework_codeql_test.prompt.md). The outer fence was prematurely closed by inner triple-backtick code blocks, breaking Markdown rendering.Future Works
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.