[ refactor ] rename constructors of Data.List.Base.InitLast and friends - #3090
Open
jamesmckinna wants to merge 1 commit into
Open
[ refactor ] rename constructors of Data.List.Base.InitLast and friends#3090jamesmckinna wants to merge 1 commit into
Data.List.Base.InitLast and friends#3090jamesmckinna wants to merge 1 commit into
Conversation
jamesmckinna
added
deprecation
refactoring
breaking
cosmetic
style-guide
status: blocked-by-issue
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3089
Question: we typically are happy to overload
[]as a constructor name, rather than here, where we might ought to also rename theInitLastconstructor to‵[]... but would that be Going Too Far?UPDATED: now marked as blocking on #3089 until/unless we can agree what any convention/policy for naming here should actually be...!?