Fall back to sitemap discovery when llms.txt is less than max links#39
Merged
Fall back to sitemap discovery when llms.txt is less than max links#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the issue described in #27 - when
--max-linksis greater than the number of links in llms.txt, fall back to the sitemap to discover additional documentation URLs. This accounts for cases where you want to sample a more representative/complete range of URLs than llms.txt alone provides.This also spawned the investigation ticket #38 . We should consider that as a separate unit of work.
The scope of this PR was relatively small, but it added new test surface area that required adding new mocks across many test files, so the test scope makes it look larger than it actually is.