Repository navigation
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
josjeon
marked this pull request as ready for review
October 9, 2026 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a directly measured SDK control-check elapsed metric for one pre/post invocation. This is the caller's actual wait for the check, including local evaluation and the conditional remote call, rather than an average/max/sum of individual control durations.
Context: aggregate control time request and per-step average discussion.
Behavior and boundary
EvaluationResult.control_check_elapsed_msandcontrol_check_id. New SDK helper invocations measure elapsed with a monotonic clock; legacy/manual results remain null unless measured.execution_duration_msand the server evaluation response schema.Observability
ControlCheckEventand optionalControlCheckEventSinkcapability. Existing control-only sinks remain compatible; the HTTP control-execution ingestion endpoint receives no whole-check payload.agent_control.control_checkspan with captured invocation start and monotonic-derived end, correlated to its parent step. Metadata contains only safe check ID/stage/elapsed/status; no input/output or exception text.Validation
make models-test: 76 passed.make telemetry-test: 20 passed.make prepush: all repository lint/type checks and Galileo extra checks passed.git diff --checkpassed. No dependency or lockfile changes.Full DB-backed server/SDK integration, deployment and remote load testing were not run for this SDK/telemetry draft.