Repository navigation
Update agents.py - #1293
Closed
Moreauju wants to merge 1 commit into
Closed
Update agents.py#1293Moreauju wants to merge 1 commit into
Moreauju wants to merge 1 commit into
Conversation
weasdown
added a commit
to weasdown/aima-python
that referenced
this pull request
Feb 5, 2025
Member
|
Thanks @Moreauju. This targets the same XYEnvironment off-by-one that has since been fixed at the source in #1303: the default bounds are now (width-1, height-1), so is_inbounds is already correct as written. Applying an extra -1 here on top of that fix would double-correct and drop the last row/column (valid range would become [0, width-2]). #1303 also fixes random_location_inbounds, which this patch didn't cover. Closing as superseded by #1303 - thanks for spotting the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.