Conversation
This PR adds support for RuboCop's Plugin feature. It replaces the ad-hoc `Inject` hack with the RuboCop plugin system introduced in RuboCop 1.72. - rubocop/rubocop#13792 - https://docs.rubocop.org/rubocop/plugin_migration_guide.html Accordingly, rubocop-airbnb has been updated to require specific versions of the following RuboCop extension plugins it depends on - rubocop-performance (`~> 1.24`) - rubocop-rails (`~> 2.30`) - rubocop-rspec (`~> 3.5`) The most significant change is that rubocop-rspec has been updated from version 2 to version 3. As a result, `RSpec/Capybara` and `RSpec/FactoryBot` have been extracted into the following extension gems: - rubocop-capybara - rubocop-factory_bot This PR adds dependencies on both rubocop-capybara and rubocop-rspec extensions to maintain the previous rubocop-rspec configuration. `RSpec/FilePath` has been split into `RSpec/SpecFilePathFormat` and `RSpec/SpecFilePathSuffix`, so the original disabling has been retained in the configuration. Similarly, `RSpec/Capybara/FeatureMethods` remains disabled as `RSpec/Dialect`. https://github.com/rubocop/rubocop-rspec/blob/v3.5.0/config/obsoletion.yml Resolves rubocop/rubocop-factory_bot#147.
koic
force-pushed
the
plugin_lint_roller
branch
from
e2f3819 to
fcdaa27
Compare
pariser
approved these changes
Mar 21, 2025
Contributor
pariser
left a comment
pariser
left a comment
There was a problem hiding this comment.
Thanks for these changes!
Contributor
|
Released as part of https://rubygems.org/gems/rubocop-airbnb/versions/8.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for RuboCop's Plugin feature.
It replaces the ad-hoc
Injecthack with the RuboCop plugin system introduced in RuboCop 1.72.Accordingly, rubocop-airbnb has been updated to require specific versions of the following RuboCop extension plugins it depends on
~> 1.24)~> 2.30)~> 3.5)The most significant change is that rubocop-rspec has been updated from version 2 to version 3. As a result,
RSpec/CapybaraandRSpec/FactoryBothave been extracted into the following extension gems:This PR adds dependencies on both rubocop-capybara and rubocop-rspec extensions to maintain the previous rubocop-rspec configuration.
RSpec/FilePathhas been split intoRSpec/SpecFilePathFormatandRSpec/SpecFilePathSuffix, so the original disabling has been retained in the configuration. Similarly,RSpec/Capybara/FeatureMethodsremains disabled asRSpec/Dialect.https://github.com/rubocop/rubocop-rspec/blob/v3.5.0/config/obsoletion.yml
Resolves rubocop/rubocop-factory_bot#147.