[docs-agent] Fix weekly link-check: 4 broken wallets links#1343
Conversation
Weekly link-check workflow flagged 4 broken `alchemy.com/docs/wallets/...` links. Each is repointed to the correct existing path (privy, aa-sdk/core) or an external official equivalent (ERC-7677 EIP for third-party paymasters; v5 session keys reference page). Refs DOCS-105
🔗 Preview Mode
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4c279ee06
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <Markdown src="../../shared/v4-code-banner.mdx" /> | ||
|
|
||
| Learn how to build DeFi applications that interact with Aave using Wallet APIs. This recipe covers supplying and withdrawing assets with both the [Core library](/docs/wallets/reference/aa-sdk/core) and the [Wallet APIs](/docs/wallets/api-reference/smart-wallets/wallet-api-endpoints/wallet-request-account) for seamless user experiences. | ||
| Learn how to build DeFi applications that interact with Aave using Wallet APIs. This recipe covers supplying and withdrawing assets with both the [Core library](/docs/wallets/quickstart) and the [Wallet APIs](/docs/wallets/api-reference/smart-wallets/wallet-api-endpoints/wallet-request-account) for seamless user experiences. |
There was a problem hiding this comment.
Point Core library references to Core documentation
This replacement sends readers from a v4 recipe that immediately uses the Core (@aa-sdk/core) tab and imports LocalAccountSigner to the v5 Wallet APIs quickstart, which does not document the direct @aa-sdk/core approach described here. In the scenario where users choose the Core implementation below, the link now gives setup instructions for a different SDK instead of the API they need.
Useful? React with 👍 / 👎.
| --- | ||
|
|
||
| Once a session key is installed, you can use it by creating a second `ModularAccountV2` whose **owner** is the session key signer and whose `accountAddress` points to the original account. Pass the session key's `entityId` and global-validation flag via `signerEntity` — these were set when you called [`encodeInstallValidation`](/docs/wallets/smart-contracts/modular-account-v2/session-keys/adding-session-keys). | ||
| Once a session key is installed, you can use it by creating a second `ModularAccountV2` whose **owner** is the session key signer and whose `accountAddress` points to the original account. Pass the session key's `entityId` and global-validation flag via `signerEntity` — these were set when you called [`encodeInstallValidation`](/docs/wallets/reference/wallet-apis-session-keys). |
There was a problem hiding this comment.
Link encodeInstallValidation to a matching guide
The new target is the Wallet APIs session-keys overview, which covers grantPermissions/wallet_createSession flows rather than the encodeInstallValidation call named in this sentence. For users trying to recover the entityId and global-validation flag for an already-installed Modular Account V2 session key, this link now lands on a different session-key flow and does not explain the values the text says were set by encodeInstallValidation.
Useful? React with 👍 / 👎.
Keep v4 recipe links versioned and expose low-level MAv2 session-key docs from the sidebar while pointing most users toward Wallet APIs. Co-Authored-By: Codex <noreply@openai.com>
Avoid implying a specific calendar range for session-key permissions examples. Co-Authored-By: Codex <noreply@openai.com>
Clarify that the Aave recipe uses Account Kit v4 and describe lower-level MAv2 docs as custom wiring paths. Co-Authored-By: Codex <noreply@openai.com>
Keep the Aave recipe on the Wallet APIs path and pair createSmartWalletClient with alchemyWalletTransport. Co-Authored-By: Codex <noreply@openai.com>
Avoid implying Wallet APIs session keys support a configured start time. Co-Authored-By: Codex <noreply@openai.com>
Summary
Fixes the weekly Wallets link-check issues and folds in follow-up content review for the affected pages.
@aa-sdk/corereference to theaa-sdkv4.x.xsource, and usesalchemyWalletTransportin the@alchemy/wallet-apisexample.Low-Level Infra > Smart Account Types > Modular Account V2, with warnings that most projects should use@alchemy/wallet-apis.Validation
pnpm exec eslint <changed MDX files>node -e "import fs from 'node:fs'; import yaml from 'js-yaml'; yaml.load(fs.readFileSync('content/docs.yml','utf8')); console.log('content/docs.yml parsed')"git diff --checkNote: I did not run the full
lycheelink check locally because thelycheebinary is not installed in this workspace/project.Linear
DOCS-105
Slack thread
Weekly Link Check thread in
#dx-developer-relations(DX Slack Bot, weekly automated report).