fix(pytest): ignore pytest internal fixture finalizers in teardown

allure-pytest/src/listener.py

@@ -179,6 +179,8 @@ def pytest_fixture_setup(self, fixturedef, request):
         before_fixture = TestBeforeResult(name=fixture_name, start=now())
         self.allure_logger.start_before_fixture(container_uuid, before_fixture_uuid, before_fixture)
 
+        internal_finalizers_count = len(getattr(fixturedef, "_finalizers", ()))
+
         outcome = yield
 
         self.allure_logger.stop_before_fixture(before_fixture_uuid,
@@ -187,8 +189,9 @@ def pytest_fixture_setup(self, fixturedef, request):
                                                statusDetails=get_outcome_status_details(outcome))
 
         finalizers = getattr(fixturedef, "_finalizers", [])
-        for index, finalizer in enumerate(finalizers):
-            finalizer_name = getattr(finalizer, "__name__", index)
+        for index in range(internal_finalizers_count, len(finalizers)):
+            finalizer = finalizers[index]
+            finalizer_name = getattr(finalizer, "__name__", index - internal_finalizers_count)
             name = f"{fixture_name}::{finalizer_name}"
             finalizers[index] = allure_commons.fixture(finalizer, parent_uuid=container_uuid, name=name)
 

tests/allure_pytest/acceptance/fixture/fixture_internal_finalizer_test.py

@@ -0,0 +1,71 @@
+from hamcrest import assert_that, ends_with, matches_regexp, not_
+from allure_commons_test.container import has_after, has_container
+from allure_commons_test.report import has_test_case
+from allure_commons_test.result import with_status
+
+
+def test_yield_fixture_has_no_phantom_internal_finalizer(allure_pytest_runner):
+    """
+    >>> import pytest
+
+    >>> @pytest.fixture
+    ... def yield_fixture():
+    ...     yield
+    ...     pass
+
+    >>> def test_example(yield_fixture):
+    ...     pass
+    """
+    allure_results = allure_pytest_runner.run_docstring()
+
+    assert_that(
+        allure_results,
+        has_test_case(
+            "test_example",
+            has_container(
+                allure_results,
+                has_after(
+                    matches_regexp(r"^yield_fixture::\d+$"),
+                    with_status("passed")
+                ),
+                not_(
+                    has_after(
+                        ends_with("::<lambda>")
+                    )
+                )
+            )
+        )
+    )
+
+
+def test_user_lambda_finalizer_is_still_reported(allure_pytest_runner):
+    """
+    >>> import pytest
+
+    >>> @pytest.fixture
+    ... def custom_lambda_fixture(request):
+    ...     request.addfinalizer(lambda: None)
+    ...     yield
+
+    >>> def test_example(custom_lambda_fixture):
+    ...     pass
+    """
+    allure_results = allure_pytest_runner.run_docstring()
+
+    assert_that(
+        allure_results,
+        has_test_case(
+            "test_example",
+            has_container(
+                allure_results,
+                has_after(
+                    matches_regexp(r"^custom_lambda_fixture::\d+$"),
+                    with_status("passed")
+                ),
+                has_after(
+                    "custom_lambda_fixture::<lambda>",
+                    with_status("passed")
+                )
+            )
+        )
+    )