Repository navigation
fix: harden accessibility service lifecycle and add desync health check - #102
Merged
Merged
Conversation
…ck for Android service interruptions
natakhot271
marked this pull request as draft
October 4, 2026 02:57
natakhot271
marked this pull request as ready for review
October 4, 2026 05:40
Contributor
Author
|
Tested Mindful launch with a debug apk! It works after a reboot + wait 30 sec to unlock, and doesn't work in Reef 4.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The root cause was a startup-time crash before unlock: Android refuses access to credential-encrypted/device-protected storage while the user is still locked. Reef was attempting to initialize prefs too early during app startup, which could crash the process and leave the accessibility setting enabled while the service was effectively dead. This patch defers startup until the user is unlocked and safely resumes once the device is ready.
We also keep the service-health hardening in place so stale or interrupted accessibility state is easier to detect and recover from.
Steps to reproduce the bug
I am running Shizuku and debugging though its aShell on my phone.
adb logcat -d | grep -iE "ReefApp|IllegalStateException|SharedPreferences|credential encrypted storage|user.*unlock"pidof dev.pranav.reefdumpsys accessibility | grep -E "Enabled services|Bound services" -A 2Fixes: #101, #88
Notes