pcm: reject invalid multi bindings without assertions - #524
Open
HarshRajSinghania wants to merge 1 commit into
Open
pcm: reject invalid multi bindings without assertions#524HarshRajSinghania wants to merge 1 commit into
HarshRajSinghania wants to merge 1 commit into
Conversation
Fixes alsa-project#523 Signed-off-by: Harsh Raj Singhania <raj.harshraut@gmail.com>
HarshRajSinghania
force-pushed
the
fix/pcm-multi-sparse-binding
branch
from
September 11, 2026 19:34
a6848c1 to
aa0a70b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523
The
multiPCM parser initializes unused binding slots withslave_idx == -1.snd_pcm_multi_open()previously evaluatedschannels[i] < schannels_count[sidxs[i]]before checking for an unbound slot, causing a negative array index and an assertion abort for sparse binding configurations.This patch:
-EINVALinstead of relying on assertions for malformed configuration.Reproducer from #523:
Before the patch, alsa-lib aborts with:
The fix makes the malformed configuration fail cleanly with
-EINVAL.Reported and fixed by Harsh Raj Singhania.