Repository navigation
Fix tab indicator clipping by removing matchContentSize in JetLaggedHeaderTabs - #1707
Merged
Merged
Conversation
kuvandikov
changed the title
kuvandikov
changed the title
Closed
4 tasks done
Contributor
Author
|
Hi @srikrishnasakunia, @riggaroo, I’ve looked into this issue and implemented a fix. By removing the matchContentSize = true parameter from the indicator's offset, we ensure the selection box comfortably encapsulates the full label text (e.g., 'Day', 'Week') without any clipping. I’ve tested this across all tabs, and it now aligns perfectly with the clickable area. Looking forward to your feedback! |
This was referenced Sep 10, 2026
This was referenced Oct 8, 2026
riggaroo
approved these changes
Oct 16, 2026
Collaborator
|
please update with latest main changes to get build status run |
kuvandikov
force-pushed
the
fix-tab-indicator-issue-1703
branch
from
October 19, 2026 09:54
049ce32 to
5d15a04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #1703 where the tab selection indicator in the
JetLaggedsample was incorrectly sized and clipping the label text.Changes:
matchContentSize = truefrom.tabIndicatorOffset()in the indicator implementation.Verification:
Related Issues
Fixes #1703