fix(@angular/build): assert that asset input paths are within workspace root#33223
Closed
alan-agius4 wants to merge 1 commit into
Closed
fix(@angular/build): assert that asset input paths are within workspace root#33223alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces validation to ensure that asset paths are contained within the workspace root across different Angular builders. It adds a new isSubDirectory utility and implements checks in both the application and browser builders, along with corresponding unit tests. Feedback from the reviewer highlights a potential mismatch in error messages within the new test cases for string-based asset patterns. Additionally, improvements were suggested for the path validation logic to correctly handle edge cases where directory names might start with double dots and to ensure platform-specific path separators are used.
alan-agius4
force-pushed
the
asset-validation-20
branch
5 times, most recently
from
3fbfd01 to
f82ec6e
Compare
…ce root Ensure that asset patterns defined as objects with an 'input' property are validated to be within the workspace root. - In '@angular/build', introduce a shared 'isSubDirectory' utility and apply it to both 'normalizeAssetPatterns' and 'resolveAssets'. - In '@angular-devkit/build-angular', apply similar validation during 'normalizeAssetPatterns'. - Add and update integration and E2E tests to prevent regressions from absolute and relative path traversal attempts.
alan-agius4
force-pushed
the
asset-validation-20
branch
from
f82ec6e to
e2c6bfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that asset patterns defined as objects with an 'input' property are validated to be within the workspace root.