Repository navigation
Conversation
… in an NgModule With `addTypeToClassName: false`, the component and directive schematics name the class without the type, but the NgModule declaration was added with the type appended (e.g. `FooComponent`), so the module no longer compiled. Honour `addTypeToClassName` when computing the declared symbol. Fixes angular#34447
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for generating component and directive class names without their type suffix when addTypeToClassName is set to false. This is implemented by updating the DeclarationToNgModuleOptions interface and the addDeclarationToNgModule utility, and is verified with new unit tests. Feedback on the changes points out a bug in the new component schematic test where the assertion expects App instead of AppComponent in the module declarations, which will cause the test to fail.
alan-agius4
added
target: patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
addTypeToClassName: false, the component and directive schematics name the class withoutthe type, but the NgModule declaration was added with the type appended (e.g.
FooComponent),so the module no longer compiled.
Honour
addTypeToClassNamewhen computing the declared symbol.Fixes #34447