Repository navigation
[Backport 21.2.X ] fix(@angular/build): serialize server manifest asset paths - #34532
Merged
alan-agius4 merged 2 commits intoOct 26, 2026
Merged
alan-agius4 merged 2 commits into
alan-agius4 merged 2 commits into
Conversation
Serialize the values embedded in the generated server manifests with JSON.stringify, so a prerendered route such as ssg/customer's-choice no longer produces an invalid manifest.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Angular server application manifest generation to use JSON.stringify instead of direct string interpolation for asset paths, hashes, base hrefs, and entry points. This ensures that paths containing JavaScript string delimiters, such as single quotes, are correctly serialized and do not cause syntax errors in the generated executable manifest. Unit and end-to-end tests have been added to verify this behavior. As there are no review comments, no additional feedback is provided.
alan-agius4
approved these changes
Oct 26, 2026
alan-agius4
added
action: merge
alan-agius4
approved these changes
Oct 26, 2026
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #34493