Repository navigation
fix(@schematics/angular): generate pnpm-workspace.yaml with allowBuilds for pnpm projects - #34630
Merged
dgp1130 merged 2 commits intoNov 4, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for generating a pnpm-workspace.yaml template with predefined allowBuilds configurations when PNPM is selected as the package manager. It also refactors the PackageManager class to handle ignoreScripts defaults more consistently and adds corresponding unit tests. Feedback on the changes suggests destructuring ignoreScripts with a default value of true in the package manager's add method to improve consistency with the install method.
alan-agius4
added
action: review
alan-agius4
force-pushed
the
fix/pnpm-workspace-allow-builds
branch
from
November 2, 2026 11:46
b936b2f to
bb007ed
Compare
…ds for pnpm projects Starting in pnpm 11, `strictDepBuilds` is enabled by default and pnpm fails with `ERR_PNPM_IGNORED_BUILDS` when any dependency in the graph declares lifecycle build scripts that are not listed in `allowBuilds` in `pnpm-workspace.yaml`. Generate a `pnpm-workspace.yaml` file when scaffolding a new workspace with `pnpm` that configures `allowBuilds` to `false` for the transitive build dependencies (`@parcel/watcher`, `esbuild`, `lmdb`, and `msgpackr-extract`), which already ship prebuilt native binaries via `optionalDependencies` and do not need their fallback install scripts to execute. Fixes angular#34622
…lowBuilds for pnpm projects
alan-agius4
force-pushed
the
fix/pnpm-workspace-allow-builds
branch
from
November 2, 2026 12:11
6a7df1f to
bc870b8
Compare
dgp1130
approved these changes
Nov 4, 2026
dgp1130
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in pnpm 11,
strictDepBuildsis enabled by default and pnpm fails withERR_PNPM_IGNORED_BUILDSwhen any dependency in the dependency graph declares lifecycle build scripts that are not listed inallowBuildsinpnpm-workspace.yaml.Generate a
pnpm-workspace.yamlfile when scaffolding a new workspace withpnpm(@schematics/angular:workspace) that configuresallowBuildstofalsefor the transitive build dependencies (@parcel/watcher,esbuild,lmdb, andmsgpackr-extract), which already ship prebuilt native binaries viaoptionalDependenciesand do not need their fallback install scripts to execute.Fixes #34622