fix(opencode): include linked directories in file search index#18291
Open
t7r0n wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): include linked directories in file search index#18291t7r0n wants to merge 2 commits intoanomalyco:devfrom
t7r0n wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Added a follow-up fix for the Windows unit timeout seen on this PR. What changed:
Why:
Local validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18182
Type of change
What does this PR do?
@file autocomplete andfind.filesrely onFile.search(), which uses a cache built inFile.scan().That scan used
Ripgrep.files({ cwd })without following links, so files under junction/symlink directories were not indexed.This PR updates the scan to use
follow: trueand adds a regression test that creates a linkeddocsdirectory and verifiesdocs/linked/entry.tsis returned byFile.search().How did you verify your code works?
bunx prettier --check src/file/index.ts test/file/index.test.tsbun test --timeout 30000 test/file/index.test.ts -t "File.search()"bun test --timeout 30000 test/file/ripgrep.test.tsScreenshots / recordings
N/A (non-UI change)
Checklist