-
Notifications
You must be signed in to change notification settings - Fork 13.7k
refactor(server): replace Bun serve with Hono node adapters #18335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thdxr
wants to merge
91
commits into
dev
Choose a base branch
from
refactor/hono-server
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+525
−371
Open
Changes from all commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
656fa19
refactor: lsp server and core improvements
thdxr e8ee1e2
sync
thdxr 173128d
Update packages/opencode/src/npm/index.ts
thdxr 27f3598
Update packages/opencode/src/util/which.ts
thdxr 0e176d3
sync
thdxr 528daf5
core: dynamically resolve formatter executable paths at runtime
thdxr a9b01be
core: disable npm bin links to fix package installation in sandboxed …
thdxr 0cdd4e4
core: fix dependency installation failures behind corporate proxies o…
thdxr 4c57e39
core: enable npm bin links on non-Windows platforms to allow plugin e…
thdxr 85c2bb3
core: fix npm dependency installation on Windows CI by disabling bin …
thdxr 124a8ab
tui: export sessions using consistent Filesystem API instead of Bun.w…
thdxr b1a15d5
sync
thdxr ceb79c7
core: fix CLI tools from npm packages not being accessible after inst…
thdxr 0ff8bfe
sync
thdxr 58cf092
core: log npm install errors to console for debugging dependency fail…
thdxr 0faa191
sync
thdxr 58a4cd0
sync
thdxr 2678ceb
sync
thdxr 3c2fda4
core: fix custom tool loading to properly resolve module paths
thdxr b2eae86
tui: fix Windows plugin loading by using direct paths instead of file…
thdxr 2f41d89
fix: work around Bun/Windows UV_FS_O_FILEMAP incompatibility in tar (…
Hona 5dc8b4e
core: add Node.js runtime support
thdxr 406d216
refactor(server): replace Bun serve with Hono node adapters
thdxr 070c167
core: bundle database migrations into node build and auto-start serve…
thdxr d4e51e0
sync
thdxr d67e877
core: remove shell execution and server URL from plugin API
thdxr 5f277d1
core: return structured server info with stop method from workspace s…
thdxr 21e72cb
core: cleaner error output and more flexible custom tool directories
thdxr 4d81e2d
sync
thdxr a28648f
core: enable running in non-Bun environments by using standard Node.j…
thdxr 4d5da96
sync
thdxr 040700d
unbreak
thdxr b99de41
refactor(npm): inline pkgPath and lockPath variables
thdxr cb5674e
sync
thdxr 6ad171d
Merge branch 'dev' into opencode-2-0
thdxr 7910ce5
fix: guard Npm.which() against infinite loop when .bin is empty (#16961)
Hona 870a573
refactor: lsp server and core improvements
thdxr 6722ee2
sync
thdxr e6bf830
Update packages/opencode/src/npm/index.ts
thdxr c10b588
Update packages/opencode/src/util/which.ts
thdxr 4a6a18c
sync
thdxr 721b240
core: dynamically resolve formatter executable paths at runtime
thdxr 8e102d1
core: disable npm bin links to fix package installation in sandboxed …
thdxr 1b408cf
core: fix dependency installation failures behind corporate proxies o…
thdxr 0b5d54f
core: enable npm bin links on non-Windows platforms to allow plugin e…
thdxr ca26e63
core: fix npm dependency installation on Windows CI by disabling bin …
thdxr fac0aec
tui: export sessions using consistent Filesystem API instead of Bun.w…
thdxr 791e27d
sync
thdxr dd0c258
core: fix CLI tools from npm packages not being accessible after inst…
thdxr 655fe20
sync
thdxr ced125a
core: log npm install errors to console for debugging dependency fail…
thdxr a18528a
sync
thdxr 5ea92ea
sync
thdxr 2a98920
sync
thdxr 5325b2e
core: fix custom tool loading to properly resolve module paths
thdxr 5e069aa
tui: fix Windows plugin loading by using direct paths instead of file…
thdxr 4f82248
fix: work around Bun/Windows UV_FS_O_FILEMAP incompatibility in tar (…
Hona 0ec4258
core: add Node.js runtime support
thdxr 88dae67
refactor(server): replace Bun serve with Hono node adapters
thdxr 66342ac
core: bundle database migrations into node build and auto-start serve…
thdxr 4cba561
sync
thdxr 0b686b8
core: remove shell execution and server URL from plugin API
thdxr 3154f0a
core: return structured server info with stop method from workspace s…
thdxr 190319f
core: cleaner error output and more flexible custom tool directories
thdxr 1ac3971
sync
thdxr bca723e
core: enable running in non-Bun environments by using standard Node.j…
thdxr 27ab51f
sync
thdxr be6f590
unbreak
thdxr f0b7c8c
refactor(npm): inline pkgPath and lockPath variables
thdxr 2e04b66
sync
thdxr fb63fd7
cleanup
thdxr 04954a9
Merge remote-tracking branch 'origin/opencode-2-0' into opencode-2-0
thdxr 63af295
Merge origin/dev into opencode-2-0
thdxr bd7a4ce
sync
thdxr b5ebc54
Merge remote-tracking branch 'origin/dev' into opencode-2-0
thdxr 48e867e
Merge remote-tracking branch 'origin/dev' into opencode-2-0
thdxr 850dbb9
Merge remote-tracking branch 'origin/dev' into opencode-2-0
thdxr 0293a8b
chore: revert changes overlapping with #18308
thdxr 08b6d9c
sync
thdxr fcf1bb0
chore: update lockfile and package.json
thdxr 2bfe81e
chore: extract SQLite abstraction into separate PR (#refactor/sqlite-…
thdxr 9439a56
chore: revert drizzle upgrade (extracted to sqlite PR)
thdxr f5783c4
chore: extract portable process changes into #18318
thdxr d473b7e
chore: extract which/global changes into #18320
thdxr b9b210a
Merge branch 'dev' into opencode-2-0
thdxr cbc40a5
chore: extract node entry point into #18324
thdxr 65e7862
chore: extract OAuth changes into #18327
thdxr 3eeeec3
chore: extract misc fixes into #18328
thdxr b77c797
Merge branch 'dev' into refactor/hono-server
thdxr 37ff5aa
Merge branch 'dev' into refactor/hono-server
thdxr a6bff14
Merge branch 'dev' into refactor/hono-server
thdxr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listenreturns before the server is ready and silently swallows bind errorsserver.listen()is asynchronous — the server is not actually bound to the port whenListenreturns. Unlike the analogousServer.listen()inserver.ts(which wraps the call in a Promise and resolves on the"listening"event), this implementation returns immediately, creating a race condition for callers. Additionally, any"error"event (e.g.EADDRINUSE) is silently ignored.The function should await the
"listening"event and reject on"error", matching the pattern in the main server: