fix: add light appearance support to themes missing it#18401
Open
IamCoder18 wants to merge 1 commit intoanomalyco:devfrom
Open
fix: add light appearance support to themes missing it#18401IamCoder18 wants to merge 1 commit intoanomalyco:devfrom
IamCoder18 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Add proper light-mode color definitions to 5 themes: - nightowl.json: added Night Owl Light palette - ayu.json: added Ayu Mirage (light variant) colors - aura.json: added Aura light palette colors - catppuccin-frappe.json: added Catppuccin Latte as light variant - catppuccin-macchiato.json: added Catppuccin Latte as light variant These themes previously had identical colors for dark and light modes, making the light appearance toggle ineffective.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potential duplicate: PR #10559: feat(opencode): support light appearance for all catppuccin themes This PR appears to be related as it addresses light appearance support specifically for Catppuccin themes, which overlaps with the current PR #18401 that adds light mode support to Catppuccin Frappe and Catppuccin Macchiato (among other themes). |
Author
|
This PR addresses the missing light modes for Catppuccin themes (#10512) while also expanding the fix to include Night Owl, Ayu, and Aura to provide a complete fix for the current theme set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proper light-mode color definitions to 5 themes that previously had identical colors for dark and light modes, making the light appearance toggle ineffective.
Issue for this PR
Closes #18397
Type of change
What does this PR do?
There were 5 color themes (Night Owl, Ayu, Aura, Catppuccin Frappe, Catppuccin Macchiato) that only had dark mode colors, even in light mode. This PR adds proper light mode colors to the theme definition and uses the official light variant of the color palette.
How did you verify your code works?
I verified my code works by comparing
opencodeandbun run dev. I've also attached a recording below to confirm it works.Screenshots / recordings
2026-03-20.08-14-42.mp4
Checklist