fix(app): support slash command picker on any line of multiline input#35519
Open
0xSkybreaker wants to merge 1 commit into
Open
fix(app): support slash command picker on any line of multiline input#355190xSkybreaker wants to merge 1 commit into
0xSkybreaker wants to merge 1 commit into
Conversation
fix(app): support slash command picker on any line of multiline input The slash command picker used `rawText.match(/^\/(\S*)$/)` which requires the entire input to start with `/`. This means typing text first, then Shift+Enter, then `/` on a new line would not trigger the picker. Fix by checking only the text before the cursor position for a line-start `/`, matching the same pattern used for @mention triggers. This allows users to compose multiline prompts and trigger slash commands on any line. Fixes anomalyco#34693 Co-Authored-By: Claude <noreply@anthropic.com> @
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35520
Type of change
What does this PR do?
The slash command picker (
/) only worked on the first line of multiline input. The regex/^\/(\S*)$/matched against the entirerawText, requiring the text to start with/. In multiline input where/was on a later line, the regex failed to match.This fix:
rawText.substring(0, cursorPosition)) — same as how the@mention picker already works/(?:^|\n)\/(\S*)$/to match a/at the start of any lineHow did you verify your code works?
Tested locally with
bun dev:/on different lines — the slash command picker appears on any line@mentions — continues to work as beforeScreenshots / recordings
Not applicable — no UI change.
Checklist