feat(app): restyle revert dock for v2#35560
Draft
usrnk1 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Restyles the composer "rolled back messages" dock (
SessionRevertDock) to the v2 design so it matches the v2 release.DockTray/Button/IconButtonforButtonV2/IconV2/IconButtonV2and moves colors, spacing, radius and typography onto the--v2-*tokens from Figma (layer-01 surface, base border, muted icon/text, 42px header, 16px insets, v2 neutral restore button).outline-reseticon to the v2 icon sprite and shows it before the "N rolled back messages" heading, to visually separate the summary row from the message list.settings.general.newLayoutDesigns()is on, and the originalDockTrayrendering stays as the fallback, so prod (v1 layout) is unchanged.The tricky part is the layout: the composer input overlaps the dock's bottom by 18px (
session-composer-region-controller.tslift()). The first pass clipped the header (collapsed) and the last restore row (expanded). The fix keeps a dedicated 18px "sacrificial" spacer that is the only thing the composer overlaps, and puts it outside the scroll viewport so scrolling rows can never hide behind the composer.How did you verify your code works?
bun typecheckwhile iterating, plus the fullturbo typecheckthat runs on push (all 30 packages pass).Composer/Revert Dock) that renders the real dock above a mock composer card reproducing the 18px overlap, with a Layout toggle to preview both the v2 and v1 fallback.onRestoreonly mutates local story state, so the collapsed/expanded/scroll cutoff behavior can be checked in isolation.Screenshots / recordings
Storybook: Composer/Revert Dock (
1 rolled back,3 rolled back,6 rolled back (scrolls)). Figma reference:Desktop Q3 2026, node22-2835.Checklist