fix(nvidia): send correct reasoning control for MiniMax M3#35612
Closed
bazzdug-arch wants to merge 1 commit into
Closed
fix(nvidia): send correct reasoning control for MiniMax M3#35612bazzdug-arch wants to merge 1 commit into
bazzdug-arch wants to merge 1 commit into
Conversation
NVIDIA NIM's MiniMax-M3 controls reasoning via chat_template_kwargs.thinking_mode (enabled/disabled/adaptive), not the Anthropic-style thinking.type shape. The openai-compatible branch was sending the wrong parameter, so the reasoning effort control had no effect on NVIDIA. Route the openai-compatible (NVIDIA) case to chat_template_kwargs while keeping the Anthropic path unchanged.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Collaborator
|
this will break the minimax provider, incorrect. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NVIDIA NIM's MiniMax-M3 controls reasoning via \chat_template_kwargs.thinking_mode\ (see https://docs.api.nvidia.com/nim/reference/minimaxai-minimax-m3-infer), not the Anthropic-style \ hinking: { type: ... }\ shape.
The \�ariants()\ branch for \minimax-m3\ was sending the Anthropic format for both the Anthropic and the openai-compatible (NVIDIA) providers, so on NVIDIA the reasoning/effort control had no effect - the wrong value was sent.
Change
Route the @ai-sdk/openai-compatible\ (NVIDIA) case to \chat_template_kwargs.thinking_mode\ (\disabled\ / \�daptive\ / \enabled) while keeping the Anthropic path unchanged.
Test plan