fix(opencode): clarify edit not-found error to reflect fuzzy fallbacks - #45092
Open
arpankanwer wants to merge 1 commit into
Open
fix(opencode): clarify edit not-found error to reflect fuzzy fallbacks#45092arpankanwer wants to merge 1 commit into
arpankanwer wants to merge 1 commit into
Conversation
The error claimed exact whitespace matching was required, but the replacer chain normalizes whitespace, indentation and escapes before failing. Update the message to state that exact and fuzzy fallbacks were attempted and guide callers to re-read the file. Fixes anomalyco#44996
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
arpankanwer
marked this pull request as ready for review
August 25, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44996
Type of change
What does this PR do?
The
edittool reported exact whitespace matching was required, butreplace()inpackages/opencode/src/tool/edit.tstries 8 fuzzy replacers (LineTrimmedReplacer, WhitespaceNormalizedReplacer, IndentationFlexibleReplacer, etc.) before failing. The error text misled callers to re-check whitespace that would already have been tolerated.Changed only the not-found throw at
edit.ts:725to state that exact and fuzzy fallbacks were attempted and to re-read the file. The second throw for multiple matches was left unchanged.How did you verify your code works?
edit.tsaround L720-730 and confirmed the new string.packages/opencode/test/tool/edit.test.tsusestoContain("Could not find oldString")so existing tests stay compatible.Screenshots / recordings
N/A — string change only.
Checklist