chore(ci): scope workflow permissions and cancel stale typecheck runs - #45095
Open
arpankanwer wants to merge 1 commit into
Open
chore(ci): scope workflow permissions and cancel stale typecheck runs#45095arpankanwer wants to merge 1 commit into
arpankanwer wants to merge 1 commit into
Conversation
Add missing concurrency group to typecheck.yml so stale runs are cancelled on new pushes (matching test.yml dev/PR isolation logic). Add explicit permissions: contents: read to typecheck.yml, storybook.yml and notify-discord.yml to avoid falling back to the org default and keep GITHUB_TOKEN least-privilege. Fixes anomalyco#44671 Fixes anomalyco#44669
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found: PR #44670: "chore: set explicit permissions on workflows missing them" This appears to be directly related to PR #45095. Both PRs address adding explicit You should check the status and content of PR #44670 to determine if it's a true duplicate or if these PRs complement each other differently. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
arpankanwer
marked this pull request as ready for review
August 25, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44671
Closes #44669
Type of change
What does this PR do?
typecheck.ymlhad noconcurrencyand nopermissions.storybook.ymlandnotify-discord.ymlhad nopermissions. Other workflows pinpermissions: contents: read, so these were oversights that leaveGITHUB_TOKENat the org default and waste runners on stale pushes.Added the same dev/PR-isolated concurrency group from
test.ymltotypecheck.ymland addedpermissions: contents: readto all three workflows, keeping placementconcurrency -> permissions -> jobs.How did you verify your code works?
python3 -c "import yaml; yaml.safe_load(open(...))"on all three workflows — parses OK.bun x prettier --checkon the three files — style OK.concurrencygroup string totest.yml:10-14and verifiedgrep -L "permissions:"no longer lists these files.Screenshots / recordings
N/A — CI config only.
Checklist