fix(app): handle Up from no selection in directory picker - #45096
Open
arpankanwer wants to merge 1 commit into
Open
fix(app): handle Up from no selection in directory picker#45096arpankanwer wants to merge 1 commit into
arpankanwer wants to merge 1 commit into
Conversation
nextSuggestionIndex assumed current was always in [0,count) and used (current+delta+count)%count, so Up (-1) from no-selection (-1) wrapped to penultimate (count-2) instead of last (count-1). Down was correct. Handle the sentinel -1 explicitly so initial Up mirrors initial Down. Fixes anomalyco#44960
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
arpankanwer
marked this pull request as ready for review
August 25, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44960
Type of change
What does this PR do?
nextSuggestionIndexinpackages/app/src/components/directory-picker-domain.ts:218used(current + delta + count) % count. With initialactiveSuggestion = -1(no selection),Up (-1)from-1gavecount-2(penultimate) instead ofcount-1(last).Downwas correct by accident.Added explicit handling for the
-1sentinel: return0forDownandcount-1forUp. Only this function is touched, used bydialog-select-directory-v2.tsx.How did you verify your code works?
bun --cwd packages/app test src/components/directory-picker-domain.test.ts— 23 pass, 0 fail (78 expects).nextSuggestionIndex(-1, -1, 4)now returns3(was2), and(-1, 1, 4)=0,(3,1,4)=0,(0,-1,4)=3unchanged.Screenshots / recordings
N/A — keyboard navigation fix, verified via unit test.
Checklist