fix(app): scroll overflowing composer controls - #47444
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
No linked issue; fixes composer toolbar overflow reported during desktop testing.
Type of change
What does this PR do?
Makes the agent/model/variant controls horizontally scrollable while keeping the plus button and Submit/Queue/Steer actions fixed. Gradient masks appear only at edges with hidden content and disappear at the scroll endpoints, without adding padding. Keeps a 4px gap beside the plus and a 12px gap beside the submit actions, mirrored in RTL.
Adds a long-label Storybook fixture and browser coverage for scrolling, endpoint spacing, keyboard/menu access, resizing, and optional Queue/Steer actions.
How did you verify your code works?
bun typecheckinpackages/apppassed.bun run test:components composer.spec.ts --workers=2 --grep-invert 'raises the docked composer'inpackages/app: 14 passed.Screenshots / recordings
Checked the production composer in Storybook in light/dark mode, narrow layouts, and RTL. Screenshots are not attached; the interactive reproduction is OpenCode → Composer → Flow → Toolbar Overflow, with controls for no shortcut, Queue, and Steer.
Checklist