Skip to content

fix(app): hide the closed side region over the side terminal - #54052

Merged
Hona merged 1 commit into
v2from
dark-card-edge
Oct 9, 2026
Merged

Hona merged 1 commit into
v2from
dark-card-edge

Conversation

@Hona

@Hona Hona commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Issue for this PR

No linked issue.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

With the terminal docked on the side, a straight light line can sit on the terminal panel's top edge and stick out past its rounded corners.

  • Cause: when the side region (Review, Browser, …) closes while the side terminal is open, it stays mounted at zero height. The close animation hides it with visibility: hidden, but only while data-opened="false" is set. Anything that recomputes sideMotion without a region change, such as turning the terminal off and on, clears data-opened. The zero-height #review-panel then shows again. A zero-height box cannot round its corners, so its --v2-elevation-raised ring paints as a flat line across the full column width, on top of the terminal panel's rounded top edge.
  • Fix: keep the region hidden while it is closed, except during its own close animation.
<div
  data-slot="session-side-region-presence"
  data-opened={sideMotion().animateRegion ? sideMotion().region : undefined}
  class="absolute inset-0"
  classList={{ invisible: !screen.side.region.open() && !sideMotion().animateRegion }}
>

The region still collapses with its animation, reopens normally, and stays mounted while the side terminal is open.

How did you verify your code works?

  • Desktop dev build, dark theme: open Review, open the side terminal (ctrl+backquote), close Review, then turn the terminal off and on.
  • Before: the closed region is visible, 0px tall, at the terminal's top edge. After: the same element is visibility: hidden, and reopening Review restores it to its full height.

Screenshots / recordings

Top of the side terminal panel, dark theme, 2x zoom:

Before After
Before: a straight line runs across the terminal panel's top edge and past both rounded corners After: the terminal panel's top corners are round and clean

Top-left and top-right corners, 10x zoom, dark range brightened:

Before After
Before: the line overhangs both rounded corners After: the edge follows both corners

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Copilot AI balanced review requested due to automatic review settings October 9, 2026 02:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

A closed side region stays mounted at zero height while the side terminal is open. Once anything resets its presence animation, such as turning the terminal off and on, the zero-height frame becomes visible again and its shadow draws a flat line over the terminal's top edge, past its rounded corners. Keep it hidden while closed, outside its own close animation.
@Hona
Hona requested a review from Brendonovich as a code owner October 9, 2026 02:50
@Hona Hona changed the title fix(ui): even out the dark panel outline fix(app): hide the closed side region over the side terminal Oct 9, 2026
@Hona
Hona merged commit f530998 into v2 Oct 9, 2026
11 checks passed
@Hona
Hona deleted the dark-card-edge branch October 9, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants