Repository navigation
fix(app): hide the closed side region over the side terminal - #54052
Merged
Merged
Conversation
A closed side region stays mounted at zero height while the side terminal is open. Once anything resets its presence animation, such as turning the terminal off and on, the zero-height frame becomes visible again and its shadow draws a flat line over the terminal's top edge, past its rounded corners. Keep it hidden while closed, outside its own close animation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
No linked issue.
Type of change
What does this PR do?
With the terminal docked on the side, a straight light line can sit on the terminal panel's top edge and stick out past its rounded corners.
visibility: hidden, but only whiledata-opened="false"is set. Anything that recomputessideMotionwithout a region change, such as turning the terminal off and on, clearsdata-opened. The zero-height#review-panelthen shows again. A zero-height box cannot round its corners, so its--v2-elevation-raisedring paints as a flat line across the full column width, on top of the terminal panel's rounded top edge.The region still collapses with its animation, reopens normally, and stays mounted while the side terminal is open.
How did you verify your code works?
ctrl+backquote), close Review, then turn the terminal off and on.visibility: hidden, and reopening Review restores it to its full height.Screenshots / recordings
Top of the side terminal panel, dark theme, 2x zoom:
Top-left and top-right corners, 10x zoom, dark range brightened:
Checklist