Skip to content

Migrate ansible 11 -> 12 : bug corrected#405

Closed
pulse-mind wants to merge 1 commit intoansistrano:masterfrom
pulse-mind:migrate-ansible11-ansible12-patch2c
Closed

Migrate ansible 11 -> 12 : bug corrected#405
pulse-mind wants to merge 1 commit intoansistrano:masterfrom
pulse-mind:migrate-ansible11-ansible12-patch2c

Conversation

@pulse-mind
Copy link
Copy Markdown
Contributor

No description provided.

@pulse-mind
Copy link
Copy Markdown
Contributor Author

Sorry for these bad changes, I tested this one on my deployement

@ricardclau
Copy link
Copy Markdown
Member

This does not change anything I believe

@pulse-mind
Copy link
Copy Markdown
Contributor Author

This does not change anything I believe

It changes the behavior, without that it was failing in some cases when I used it on my deploy

@ricardclau
Copy link
Copy Markdown
Member

ricardclau commented Nov 7, 2025 via email

@pulse-mind
Copy link
Copy Markdown
Contributor Author

It is not easy for me, I spent 2 days to work on ANXS.postgresql and ansistrano and I shutdown one of my server to test the installation from scratch.
I tried many times from scratch, with the current version and with the version I proposed and there was a difference when retrieving the git repository, the repo was empty.
But it is up to you...

@ricardclau
Copy link
Copy Markdown
Member

Then, unless you (or someone else) can provide an example where this is useful, sorry but we don't want to add any more changes to an already convoluted workflow

@pulse-mind
Copy link
Copy Markdown
Contributor Author

you know, I provided the latest modification on this file so I was the one who did the mistake :D

@ricardclau
Copy link
Copy Markdown
Member

ricardclau commented Mar 23, 2026

Thanks for the PR. I compared it against the current master and also against the state before the original regression introduced in 12806de.

That regression was already addressed by:

At this point, this PR does not seem to fix an additional failing case on current master. The changes in tasks/update-code/git.yml are mostly rewrites of the existing conditions without a functional improvement over the current implementation.

I’m going to close this to avoid extra churn. If there is still a concrete case failing on current master, please open a new PR with that failing scenario or a regression test.

@ricardclau ricardclau closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants