Flaky Tests and bug fixes #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build is failing because of AMQ4889Test which as been fixed in #1630 |
Member
|
I would suggest to avoid mixing bug fixes and flaky tests in the same PR. It would be great to have PRs specifically for flaky tests and PRs specifically for bug fixes. |
Contributor
Author
|
I extracted the fixes in separate PRs already. Whenever they are merged. I just need to rebase against master and then squash the commits. I'll wait for the merges before to avoid duplicating the efforts. |
Member
|
@jeanouii ok, just saw the other PRs, I was confused as this PR has not been updated. Sorry about that 😄 I'm keep reviewing the PRs 😄 |
jeanouii
force-pushed
the
fix/flaky-tests-v3
branch
from
134a5e2 to
5292ea9
Compare
…NioTest to prevent errors during remote exception handling AMQ-9848 Add testQueuePauseResume to VirtualTopicsAndDurableSubsTest for queue pause/resume functionality AMQ-9847 Add assertions to QueueZeroPrefetchLazyDispatchPriorityTest for message enqueuing and availability AMQ-9841 Fix potential NPE in JMSConsumerTest by ensuring subscriptions list is not null before accessing its size Reduce maxWait timeout in SslTransportBrokerTest to improve test performance AMQ-9842 Improve JobSchedulerWithAdvisoryMessageTest to use Wait utility for queue advisory verification AMQ-9841 Enhance JMSConsumerTest to ensure correct message dispatching between consumers
jeanouii
force-pushed
the
fix/flaky-tests-v3
branch
from
5292ea9 to
5f59cdb
Compare
Contributor
Author
|
Here we go @jbonofre |
jbonofre
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.