Skip to content

fix(webconsole): the webconsole now redirect to the slave.jsp when required#1931

Merged
jbonofre merged 2 commits intoapache:mainfrom
jbonofre:gh-1920
Apr 17, 2026
Merged

fix(webconsole): the webconsole now redirect to the slave.jsp when required#1931
jbonofre merged 2 commits intoapache:mainfrom
jbonofre:gh-1920

Conversation

@jbonofre
Copy link
Copy Markdown
Member

@jbonofre jbonofre commented Apr 15, 2026

When using <broker ... startAsync="true"> in master/slave mode, the Jetty server can be started on slave.

In that case, the broker is not a "full active" broker yet, and the Web Console is poorly failing with an exception (and long stack trace in the log).

This PR fixes the Web Console, now dealing with slave broker and redirecting cleanly to slave.jsp.

NB: no impact on standalone/master broker, same behavior as today.

@jbonofre jbonofre requested review from cshannon and mattrpav April 15, 2026 15:55
…quired (slave broker with startAsync="true")
@cshannon
Copy link
Copy Markdown
Contributor

@mattrpav - Does this look ok to you? I think redirecting the page makes sense if it is running so the user knows.

cshannon
cshannon previously approved these changes Apr 15, 2026
mattrpav
mattrpav previously approved these changes Apr 15, 2026
Copy link
Copy Markdown
Contributor

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-on resolves

The BrokerXmlConfigStartTest loads all activemq-*.xml sample configs
which import jetty.xml. Since jetty.xml now has depends-on="broker" on
the invokeStart bean, the sample configs need a matching bean id.
@jbonofre jbonofre dismissed stale reviews from mattrpav and cshannon via 4f4fbb2 April 17, 2026 06:20
@jbonofre jbonofre merged commit 2b91f01 into apache:main Apr 17, 2026
19 of 20 checks passed
@jbonofre jbonofre deleted the gh-1920 branch April 17, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants