fix(webconsole): the webconsole now redirect to the slave.jsp when required#1931
Merged
jbonofre merged 2 commits intoapache:mainfrom Apr 17, 2026
Merged
fix(webconsole): the webconsole now redirect to the slave.jsp when required#1931jbonofre merged 2 commits intoapache:mainfrom
jbonofre merged 2 commits intoapache:mainfrom
Conversation
…quired (slave broker with startAsync="true")
Contributor
|
@mattrpav - Does this look ok to you? I think redirecting the page makes sense if it is running so the user knows. |
cshannon
previously approved these changes
Apr 15, 2026
…-on resolves The BrokerXmlConfigStartTest loads all activemq-*.xml sample configs which import jetty.xml. Since jetty.xml now has depends-on="broker" on the invokeStart bean, the sample configs need a matching bean id.
cshannon
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
<broker ... startAsync="true">in master/slave mode, the Jetty server can be started on slave.In that case, the broker is not a "full active" broker yet, and the Web Console is poorly failing with an exception (and long stack trace in the log).
This PR fixes the Web Console, now dealing with slave broker and redirecting cleanly to
slave.jsp.NB: no impact on standalone/master broker, same behavior as today.