Skip to content

Comments

fix S3RemoteLogIO using incorrect transfer config#62423

Open
stephen-bracken wants to merge 1 commit intoapache:mainfrom
stephen-bracken:s3-fix-transfer-config
Open

fix S3RemoteLogIO using incorrect transfer config#62423
stephen-bracken wants to merge 1 commit intoapache:mainfrom
stephen-bracken:s3-fix-transfer-config

Conversation

@stephen-bracken
Copy link
Contributor

@stephen-bracken stephen-bracken commented Feb 24, 2026


The S3RemoteLogIO class was setting use_threads=False in the transfer config arguments, but this argument is ignored if using the (now default) CRTTransferManager instead of the S3TransferManager. Setting preferred_transfer_client="classic" will use the S3TransferManager instead.

https://docs.aws.amazon.com/boto3/latest/reference/customizations/s3.html#s3-transfers

use_threads – If True, threads will be used when performing S3 transfers. If False, no threads will be used in performing transfers; all logic will be run in the current thread. Note: This value is ignored when resolved transfer manager type is CRTTransferManager.

We noticed this because some of our tasks which had very large log files (a few GB each) were causing the worker pods in kubernetes to go OOMKilled when they were uploaded to S3.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • No

@stephen-bracken stephen-bracken marked this pull request as ready for review February 24, 2026 22:14
@eladkal eladkal requested a review from vincbeck February 25, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant