fix S3RemoteLogIO using incorrect transfer config#62423
Open
stephen-bracken wants to merge 1 commit intoapache:mainfrom
Open
fix S3RemoteLogIO using incorrect transfer config#62423stephen-bracken wants to merge 1 commit intoapache:mainfrom
stephen-bracken wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
S3RemoteLogIOclass was settinguse_threads=Falsein the transfer config arguments, but this argument is ignored if using the (now default)CRTTransferManagerinstead of theS3TransferManager. Settingpreferred_transfer_client="classic"will use theS3TransferManagerinstead.https://docs.aws.amazon.com/boto3/latest/reference/customizations/s3.html#s3-transfers
We noticed this because some of our tasks which had very large log files (a few GB each) were causing the worker pods in kubernetes to go OOMKilled when they were uploaded to S3.
Was generative AI tooling used to co-author this PR?