Skip to content

Add prek hook to ban caplog usage in test files #65421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amoghrajesh wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

Add prek hook to ban caplog usage in test files #65421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions airflow-core/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,15 @@ repos:
language: python
pass_filenames: true
files: ^tests/.*\.py$
- id: check-no-caplog-in-tests
language: pygrep
name: Tests do not use caplog fixture
description: >
Do not use caplog in tests — prefer checking logic and not log output.
See https://github.com/apache/airflow/blob/main/CLAUDE.md#testing-standards
entry: \bcaplog\b
pass_filenames: true
files: ^tests/.*\.py$
- id: check-no-fab-migrations
language: pygrep
name: Check no migration is done on FAB related table
Expand Down
9 changes: 9 additions & 0 deletions providers/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,15 @@ repos:
entry: ../scripts/ci/prek/check_airflow_v_imports_in_tests.py
pass_filenames: true
files: ^.*/tests/.+\.py$
- id: check-no-caplog-in-tests
language: pygrep
name: Tests do not use caplog fixture
description: >
Do not use caplog in tests — prefer checking logic and not log output.
See https://github.com/apache/airflow/blob/main/CLAUDE.md#testing-standards
entry: \bcaplog\b
pass_filenames: true
files: ^.*/tests/.+\.py$
- id: check-sql-dependency-common-data-structure
name: Check dependency of SQL providers
description: Check dependency of SQL Providers with common data structure
Expand Down
9 changes: 9 additions & 0 deletions task-sdk/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ repos:
entry: ../scripts/ci/prek/check_init_decorator_arguments.py
pass_filenames: false
files: ^src/airflow/sdk/definitions/dag\.py$|^src/airflow/sdk/definitions/decorators/task_group\.py$
- id: check-no-caplog-in-tests
language: pygrep
name: Tests do not use caplog fixture
description: >
Do not use caplog in tests — prefer checking logic and not log output.
See https://github.com/apache/airflow/blob/main/CLAUDE.md#testing-standards
entry: \bcaplog\b
pass_filenames: true
files: ^tests/.*\.py$
- id: mypy-task-sdk
name: Run mypy for task-sdk
language: python
Expand Down
Loading